[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Mark IV reduction pipeline, release 0.2



Stupendous Man wrote:
> 
>   If you do run the code on these test images, compare your final result
> to mine.  I find a photometric solution (in file Mhra2011797.coeff)
> 
>     V=V,(V-I)  N    166  a  -8.603  0.032  b  -0.182  0.029   RMS  0.124
>     I=I,(I-V)  N    166  a  -8.258  0.024  b  -0.036  0.021   RMS  0.102

Michael,

V=V,(V-I)  N    166  a  -8.603  0.032  b  -0.182  0.029   RMS  0.124 
I=I,(I-V)  N    166  a  -8.258  0.024  b  -0.036  0.021   RMS  0.102 

Me too.
It took about 66 minutes on my computer (Celeron 333, 256MB memory)

>   Comments, suggestions, bug reports, fixes are all welcome.
> 
I did find one thing. I had to change collate_exe in collate.param (it's
set to /home/richmond/photom/collate). Maybe photom_dir from setup.param
could be prepended to collate to set this when do_setup is run? I
include some diffs that seem to work, but there's probably a better way.
Or, it might just be easier to make a note in the docs that this
parameter needs to be manually changed.
Anyway, it's great that it worked. Now I'll have to bug Tom for some
disks :-)

Mike

Diffs:
##################################################################################

--- collate.orig        Sat May 26 22:16:22 2001
+++ collate.param       Sat May 26 22:33:30 2001
@@ -15,9 +15,10 @@
 #   to count as a match.  Units are arcsec
 collate_matchrad    3.0
 
-# this is the name of the command to collage V and I data from the same
+# this is the directory where collate resides 
+# (the command to collage V and I data from the same
 #   image into a single datafile
-collate_exe        /home/tass/photom/collate
+photom_dir    /home/tass/photom
 
####################

--- collate.tcl~        Sat May 26 19:31:30 2001
+++ collate.tcl Sat May 26 22:20:13 2001
@@ -69,7 +69,7 @@
   set latitude         [get_param $param_file "latitude"]
   set longitude        [get_param $param_file "longitude"]
   set collate_matchrad [get_param $param_file "collate_matchrad"]
-  set collate_exe      [get_param $param_file "collate_exe"]
+  set photom_dir       [get_param $param_file "photom_dir"]
 
   # get information about the image
   if { [single_image_info $this_image image_info_list] != 0 } {
@@ -146,7 +146,7 @@
   # run the Unix command which collages and collates the contents
   #    of the V-band and I-band data files, to create a single
   #    data file for the field
-  if { [run_collate $collate_exe $output_dir $v_coo $v_ast $i_coo
$i_ast \
+  if { [run_collate $photom_dir/collate $output_dir $v_coo $v_ast
$i_coo $i_ast \
                         $collate_matchrad $jd $latitude $longitude
$exptime \
                         $collate_outfile] != 0 } {
     puts stderr "collate: run_collate fails for $this_image"

##################

--- setup.tcl~  Sat May 26 19:31:30 2001
+++ setup.tcl   Sat May 26 22:29:24 2001
@@ -61,6 +61,7 @@
   }
   set input_dir [get_param $param_file "input_dir"]
   set output_dir [get_param $param_file "output_dir"]
+  set photom_dir [get_param $param_file "photom_dir"]
   set refcat_dir [get_param $param_file "refcat_dir"]
   set imagelist_name [get_param $param_file "imagelist_name"]
   set latitude   [get_param $param_file "latitude"]
@@ -68,6 +69,7 @@
 
   set klist " { input_dir $input_dir } \
               { output_dir $output_dir } \
+             { photom_dir $photom_dir } \
              { refcat_dir $refcat_dir } \
              { imagelist_name $imagelist_name } \
              { latitude   $latitude } \